Google Homepage Project Feedback


#1

Hey,

I’ve put together my Google Homepage Project. Going to do some more on Flexbox and Grid before I come back and do the difficult challenge.

I was hoping to get some feedback on my project. Project is here: https://joevinten.github.io/google-homepage/ and link to the github is here: https://github.com/JoeVinten/google-homepage

Thanks in advance!

Joe


#2

I’m using FireFox and the logo + search bar + buttons are aligned to the left. Is it showing up the same for you?


#3

Ah, I didn’t realise that. It’s fine on chrome, but as you say on firefox it does that. I’ll try and fix it :slight_smile: Thanks for the heads up!


#4

It’s because you use text-align: webkit-center; on the main content section.

webkit is a chrome specific thing. You can just use text-align: center


#5

Perfect thank-you! Noticed it and tried to alter but no where near as clean as you’re explanation so will do that. Had to update the search-form to margin: 0 auto to centre that.

Thanks again.


#6

Other than the problem that I mentioned (which you already fixed), this looks absolutely solid on my phone.

Just a quick advisory, I’m more of an “intermediate” beginner lol, but your html and css code looks super clean!

Just a quick question, do you plan on using Grid or Flexbox? IIRC, Grid is not as widely supported as Flexbox.
Here’s a handy website that helps you get an idea of browser compatibility.